Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update load balancers Versions #9506

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

yankay
Copy link
Member

@yankay yankay commented Nov 21, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update load balancer Versions to resolve the CVE issue.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Upgrade the load balancer ( nginx and haproxy ) image version.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 21, 2022
@@ -1001,9 +1001,9 @@ multus_image_tag: "{{ multus_version }}"
kube_vip_image_repo: "{{ github_image_repo }}/kube-vip/kube-vip"
kube_vip_image_tag: v0.5.5
nginx_image_repo: "{{ docker_image_repo }}/library/nginx"
nginx_image_tag: 1.23.0-alpine
nginx_image_tag: 1.23.2-alpine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The job is failed:

TASK [download : download_container | Download image if required] **************
task path: /builds/kargo-ci/kubernetes-sigs-kubespray/roles/download/tasks/download_container.yml:55
Monday 21 November 2022  03:39:14 +0000 (0:00:00.094)       0:04:50.169 ******* 
FAILED - RETRYING: download_container | Download image if required (4 retries left).
FAILED - RETRYING: download_container | Download image if required (3 retries left).
FAILED - RETRYING: download_container | Download image if required (2 retries left).
FAILED - RETRYING: download_container | Download image if required (1 retries left).
fatal: [instance-1 -> instance-1]: FAILED! => {"attempts": 4, "changed": true, "cmd": ["/usr/local/bin/nerdctl", "-n", "k8s.io", "pull", "--quiet", "quay.io/kubespray/nginx:1.23.2-alpine"], "delta": "0:00:00.414519", "end": "2022-11-21 03:39:46.384432", "msg": "non-zero return code", "rc": 1, "start": "2022-11-21 03:39:45.969913", "stderr": "time=\"2022-11-21T03:39:46Z\" level=info msg=\"trying next host - response was http.StatusNotFound\" host=quay.io\ntime=\"2022-11-21T03:39:46Z\" level=fatal msg=\"failed to resolve reference \\\"quay.io/kubespray/nginx:1.23.2-alpine\\\": quay.io/kubespray/nginx:1.23.2-alpine: not found\"", "stderr_lines": ["time=\"2022-11-21T03:39:46Z\" level=info msg=\"trying next host - response was http.StatusNotFound\" host=quay.io", "time=\"2022-11-21T03:39:46Z\" level=fatal msg=\"failed to resolve reference \\\"quay.io/kubespray/nginx:1.23.2-alpine\\\": quay.io/kubespray/nginx:1.23.2-alpine: not found\""], "stdout": "", "stdout_lines": []}

The important part seems quay.io/kubespray/nginx:1.23.2-alpine: not found

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, the image should be pushed to the quay.io. But I have no write access permission :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try to give it to you asap, work trip right now so I'm having a hard time following everything

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@floryut Thank you for helping us for doing that.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@oomichi
Copy link
Contributor

oomichi commented Dec 2, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3050850 into kubernetes-sigs:master Dec 2, 2022
@yankay
Copy link
Member Author

yankay commented Dec 2, 2022

Thanks @floryut @oomichi

@floryut floryut added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 5, 2022
@floryut floryut mentioned this pull request Jan 4, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants