Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the number of nofile limits in containerd #9507

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Update the number of nofile limits in containerd #9507

merged 1 commit into from
Nov 25, 2022

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented Nov 21, 2022

Signed-off-by: bo.jiang bo.jiang@daocloud.io

What type of PR is this?
/kind feature

What this PR does / why we need it:
The nofile limit of containerd in kubespray is not enough for elasticsearch, which needs more file descriptors, so I would like to increase the value of containerd_base_runtime_spec_rlimit_nofile to 65535.
https://www.elastic.co/guide/en/elasticsearch/reference/current/file-descriptors.html

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update the number of nofile limits in containerd to 65535

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 21, 2022
@mzaian
Copy link
Contributor

mzaian commented Nov 24, 2022

Hi @ErikJiang

Can you check this comment #9319 (comment) from the previous PR which was setting this.

@yankay
Copy link
Member

yankay commented Nov 25, 2022

I think the default value 65535 is okay for most cases

Because the 16384 is not enough for lots of common applications (especially the ES).

And the docker uses 1048576:


The Rancher k3s use 1048576, k3s-io/k3s#1735

It's a small probability event that 110 pods in the same node use 16,384 fd at the same time, according to the comment #9319 (comment)
So the 6555

Look forward for others' comments.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2022
@oomichi
Copy link
Contributor

oomichi commented Nov 25, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4751089 into kubernetes-sigs:master Nov 25, 2022
@floryut floryut mentioned this pull request Jan 4, 2023
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants