-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the number of nofile limits in containerd #9507
Update the number of nofile limits in containerd #9507
Conversation
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Hi @ErikJiang Can you check this comment #9319 (comment) from the previous PR which was setting this. |
I think the default value 65535 is okay for most cases Because the 16384 is not enough for lots of common applications (especially the ES). And the docker uses 1048576:
The Rancher k3s use 1048576, k3s-io/k3s#1735 It's a small probability event that 110 pods in the same node use 16,384 fd at the same time, according to the comment #9319 (comment) Look forward for others' comments. /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ErikJiang, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Signed-off-by: bo.jiang <bo.jiang@daocloud.io> Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Signed-off-by: bo.jiang bo.jiang@daocloud.io
What type of PR is this?
/kind feature
What this PR does / why we need it:
The nofile limit of containerd in kubespray is not enough for elasticsearch, which needs more file descriptors, so I would like to increase the value of
containerd_base_runtime_spec_rlimit_nofile
to 65535.https://www.elastic.co/guide/en/elasticsearch/reference/current/file-descriptors.html
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: