Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade flannel version to v0.20.1 #9528

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Upgrade flannel version to v0.20.1 #9528

merged 1 commit into from
Dec 28, 2022

Conversation

ErikJiang
Copy link
Member

@ErikJiang ErikJiang commented Nov 30, 2022 •
edited by floryut

Signed-off-by: bo.jiang bo.jiang@daocloud.io

What type of PR is this?
/kind feature

What this PR does / why we need it:
Upgrade the flannel version to v0.20.1, and make it possible to support multiple architectures with the same tag in the image.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Flannel] Upgrade version to v0.20.1

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2022
@ErikJiang
Copy link
Member Author

@cristicalin @EppO @oomichi
how do I push the flannelcni/flannel:v0.20.1 image to quay.io/kubespray/flannel:v0.20.1?
Please give me some tips, thanks😁

@floryut
Copy link
Member

floryut commented Dec 1, 2022

@cristicalin @EppO @oomichi how do I push the flannelcni/flannel:v0.20.1 image to quay.io/kubespray/flannel:v0.20.1? Please give me some tips, thanks😁

All good, image is now pushed on quay 👍

floryut
floryut approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ErikJiang Thank you

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ErikJiang, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2022
@floryut floryut added kind/network Network section in the release note and removed kind/feature Categorizes issue or PR as related to a new feature. labels Dec 1, 2022
@ErikJiang
Copy link
Member Author

@floryut Thank you very much for your help.😊

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 9, 2022
@ErikJiang
Update the tag of the flannel image
522f84d 
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
@ErikJiang
Copy link
Member Author

ErikJiang commented Dec 27, 2022 •
edited

image
hello, @floryut and @cristicalin, I see the error "Failed to connect to the host via ssh: Shared connection to 192.168.121.230 closed." in CI, but I'm not quite sure how to fix it, cloud you give me some tips, thanks a lot. 🙂

@floryut
Copy link
Member

floryut commented Dec 27, 2022

image hello, @floryut and @cristicalin, I see the error "Failed to connect to the host via ssh: Shared connection to 192.168.121.230 closed." in CI, but I'm not quite sure how to fix it, cloud you give me some tips, thanks a lot. 🙂

All good I've retried the job, simple oneoff thing :/

@oomichi
Copy link
Contributor

oomichi commented Dec 28, 2022

Yeah, that is unrelated issue which makes our CI unstable.
This change itself seems good for me, thanks.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit 406fbdb into kubernetes-sigs:master Dec 28, 2022
@floryut floryut mentioned this pull request Jan 4, 2023
Closed
enneitex pushed a commit to enneitex/kubespray that referenced this pull request Jan 25, 2023
@ErikJiang @enneitex
Update the tag of the flannel image (kubernetes-sigs#9528)
cb5a7fa 
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@ErikJiang @HoKim98
Update the tag of the flannel image (kubernetes-sigs#9528)
8c2716b 
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@ErikJiang @nolimitkun
Update the tag of the flannel image (kubernetes-sigs#9528)
f90b509 
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@ErikJiang @pedromcpedro
Update the tag of the flannel image (kubernetes-sigs#9528)
436afed 
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>

Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@cristicalin cristicalin Awaiting requested review from cristicalin

@EppO EppO Awaiting requested review from EppO

Assignees

@oomichi oomichi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ErikJiang @floryut @k8s-ci-robot @oomichi