-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add containerd config_path #9566
Conversation
Welcome @lengrongfu! |
Hi @lengrongfu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
b9b4380
to
447da7b
Compare
/lgtm |
molecule_containerd was failed.
|
dbab56b
to
4948c5d
Compare
@oomichi @liupeng0518 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating.
just one comment for less code.
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Thanks for updating. /lgtm |
Thanks @lengrongfu for this work! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cristicalin, lengrongfu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @lengrongfu While adding the following to a var file in our cluster group_vars: I'm getting the following error at Its seems to only working if I'm changing the 'with_items' into 'with_dict' in those tasks. Am I missing something ? did I configured the vars wrongly ? Thanks |
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io> Signed-off-by: rongfu.leng <rongfu.leng@daocloud.io>
Signed-off-by: rongfu.leng rongfu.leng@daocloud.io
What type of PR is this?
What this PR does / why we need it:
Because [plugins."io.containerd.grpc.v1.cri".registry.configs."{{ addr }}".tls] config whell DEPRECATE.
Which issue(s) this PR fixes:
Fixes # #9559
Special notes for your reviewer:
Does this PR introduce a user-facing change?: