Remove ovn.kubernetes.io/ovs_dp_type from nodeSelector

[JochenFriedrich]

Remove tag preventing openvswitch container to start.

/kind bug

Fixes: #9588

Does this PR introduce a user-facing change?:

[kube-ovn] Remove ovn.kubernetes.io/ovs_dp_type from nodeSelector

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: JochenFriedrich / name: Jochen Friedrich (a9d05fc)

[k8s-ci-robot]

Welcome @JochenFriedrich!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @JochenFriedrich. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[oomichi]

/cc @oomichi

[oomichi]

This line has been added since the commit f1d0d1a to update the kube-ovn version to v1.10.7.
The commit was created based on the latest kube-ovn manifest like https://raw.githubusercontent.com/kubeovn/kube-ovn/master/dist/images/install.sh

That contains the above line.
@liupeng0518 Could you take a look at this pull request?

[JochenFriedrich]

This install script adds the tag dependent on DPDK though and has an alternative DaemonSet for ovs_dp_type=userspace.

if [ "$DPDK" = "true" -o "$HYBRID_DPDK" = "true" ]; then
kubectl label no -lovn.kubernetes.io/ovs_dp_type!=userspace ovn.kubernetes.io/ovs_dp_type=kernel --overwrite
fi

All this is all needed for HYBRID_DPDK, which kubespray doesn't support (yet?).

In the standard case, this line is not present:
https://github.com/kubeovn/kube-ovn/blob/master/dist/images/install.sh#L2596

[sirkrypt0]

Thanks for your patch, removing it makes it work for me as well! However, I was wondering whether instead of removing this line, it should be made dependent on kube_ovn_dpdk_enabled like the other settings in this file?

[liupeng0518]

This line has been added since the commit f1d0d1a to update the kube-ovn version to v1.10.7. The commit was created based on the latest kube-ovn manifest like https://raw.githubusercontent.com/kubeovn/kube-ovn/master/dist/images/install.sh

That contains the above line. @liupeng0518 Could you take a look at this pull request?

Indeed, this is a mistake.

[oomichi]

@liupeng0518 Thank you for checking it.
It is fine to merge this pull request as is for me.

/approve

[yankay]

/ok-to-test

[floryut]

/lgtm
Thank you 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, JochenFriedrich, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut,oomichi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment