Add missing defaults for external_vsphere_* variables in the csi_driver/vsphere role

[rlacko58]

roles/csi_driver/vsphere

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR adds missing environment lookup for vSphere login credentials in the csi_driver/vsphere role.

This should be already a feature as mentioned in this line:

kubespray/inventory/sample/group_vars/all/vsphere.yml

Line 5 in 6b43d6a

# external_vsphere_user: "administrator@vsphere.local" # Can also be set via the `VSPHERE_USER` environment variable

but currently, it only works with the external_cloud_controller/vsphere role.
https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/external_cloud_controller/vsphere/defaults/main.yml#L13

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rlacko58 / name: László Rafael (2e22e1a)

[k8s-ci-robot]

Welcome @rlacko58!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rlacko58. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[floryut]

@rlacko58 Thank you for the PR 🚀

Could you please rebase as #9657 has fixed the CI ?

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, rlacko58

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [floryut]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oomichi]

/lgtm