Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add resources section to all containers releated to Vsphere CSI driver #9687

Merged
merged 1 commit into from Feb 27, 2023
Merged

Add resources section to all containers releated to Vsphere CSI driver #9687

merged 1 commit into from Feb 27, 2023

Conversation

JRaver
Copy link
Contributor

@JRaver JRaver commented Jan 19, 2023 •
edited by floryut

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature
Add resources section to the Vsphere CSI driver .
In our case, we reach a bug that liveness probe container had a memory leak

/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[vSphere-csi] Add resources section to all containers releated to Vsphere CSI driver

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 19, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @JRaver. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2023
@yankay
Copy link
Member

yankay commented Jan 22, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 22, 2023
oomichi
oomichi reviewed Jan 23, 2023
View reviewed changes
Copy link
Contributor

@oomichi oomichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @oomichi

roles/kubernetes-apps/csi_driver/vsphere/templates/vsphere-csi-controller-deployment.yml.j2 Show resolved Hide resolved
@JRaver JRaver force-pushed the feature/vsphere_csi_add_resourses branch from 94386ce to 6ed4b81 Compare February 6, 2023 14:18
@oomichi
Copy link
Contributor

oomichi commented Feb 9, 2023

Thanks for updating.
looks good for me now.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@floryut
Copy link
Member

floryut commented Feb 9, 2023

/hold pending ci fix

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2023
@floryut floryut closed this Feb 27, 2023
@floryut floryut reopened this Feb 27, 2023
@floryut floryut added kind/applications Applications section in the release note and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 27, 2023
floryut
floryut approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JRaver Thank you 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, JRaver, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5cbcec8 into kubernetes-sigs:master Feb 27, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@JRaver @HoKim98
Add resources section to all containers releated to Vsphere CSI driver (
0480e1a 
kubernetes-sigs#9687)
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
@JRaver @HoKim98
Add resources section to all containers releated to Vsphere CSI driver (
b486780 
kubernetes-sigs#9687)
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@JRaver @nolimitkun
Add resources section to all containers releated to Vsphere CSI driver (
8161cab 
kubernetes-sigs#9687)
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@JRaver @pedromcpedro
Add resources section to all containers releated to Vsphere CSI driver (
5480082 
kubernetes-sigs#9687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floryut floryut floryut approved these changes

@alijahnas alijahnas Awaiting requested review from alijahnas

@LuckySB LuckySB Awaiting requested review from LuckySB

@oomichi oomichi Awaiting requested review from oomichi

Assignees

@floryut floryut

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/applications Applications section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JRaver @k8s-ci-robot @yankay @oomichi @floryut