-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cilium: disable l7-proxy when wireguard is enabled #9689
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cthu1hoo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @cthu1hoo! |
Hi @cthu1hoo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @oomichi
@@ -200,6 +200,7 @@ data: | |||
{% if cilium_encryption_type == "wireguard" %} | |||
enable-wireguard: "true" | |||
enable-wireguard-userspace-fallback: "{{ cilium_wireguard_userspace_fallback }}" | |||
enable-l7-proxy: "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to cilium/cilium#15462 the cilium community seems to consider that is an issue and try to solve it.
It is better to write some #NOTE:
here to explain this is just a workaround and we will be able to remove this after fixing the issue on the cilium side.
I think cilium/cilium#19401 supersedes this PR does it not? It certainly conflicts with cilium/cilium-cli#1405. |
Thanks @SixFive7 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When deploying kubespray we ran into a problem with Cilium pods crashlooping on startup after enabling wireguard, the error message was that l7-proxy (enabled by default) is incompatible with wireguard.
This PR automatically disables l7-proxy in Cilium config template if encryption type is set to wireguard.
Thanks for considering this.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: