Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kubernetes): Also apply kubeadm patches during upgrade #9781

Merged
merged 1 commit into from
Mar 9, 2023
Merged

fix(kubernetes): Also apply kubeadm patches during upgrade #9781

merged 1 commit into from
Mar 9, 2023

Conversation

mvandergiesen
Copy link
Contributor

@mvandergiesen mvandergiesen commented Feb 10, 2023 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
Kubespray offers support for kubeadm patches but these patches where not applied during an upgrade. According https://kubernetes.io/docs/setup/production-environment/tools/kubeadm/control-plane-flags/ the --patches flag is necessary when using kubeadm upgrade.

Which issue(s) this PR fixes:
Fixes #9773

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Apply kubeadm patches during upgrade as recommended by k8s

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mvandergiesen. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2023
@mvandergiesen
Copy link
Contributor Author

mvandergiesen commented Feb 20, 2023 •
edited
Loading

Please review this pr

@mvandergiesen
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@mvandergiesen: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yankay
Copy link
Member

yankay commented Mar 2, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 2, 2023
@liupeng0518
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2023
@liupeng0518
Copy link
Member

Fixes #9773

@oomichi
Copy link
Contributor

oomichi commented Mar 9, 2023

Thanks for fixing the issue.
Well explained and looks good to me.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mvandergiesen, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit eb4bd36 into kubernetes-sigs:master Mar 9, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@mvandergiesen @nolimitkun
fix(kubernetes): Also apply kubeadm patches during upgrade (kubernete…
fba903e 
…s-sigs#9781)
@yankay yankay mentioned this pull request May 15, 2023
Closed
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@mvandergiesen @pedromcpedro
fix(kubernetes): Also apply kubeadm patches during upgrade (kubernete…
02e4d8e 
…s-sigs#9781)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristicalin cristicalin Awaiting requested review from cristicalin

@jayonlau jayonlau Awaiting requested review from jayonlau

Assignees

@liupeng0518 liupeng0518

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubadm patches not applied during upgrade
5 participants
@mvandergiesen @k8s-ci-robot @yankay @liupeng0518 @oomichi