Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dockerfile): openssh-client support #9835

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented Feb 27, 2023

What type of PR is this?
/kind feature

What this PR does / why we need it:

openssh-client was present before this MR.
This simple commit adds it back as it let us manage ssh connections that require a private/public key instead of a password with sshpass.

Does this PR introduce a user-facing change?:

Add back openssh-client to docker image

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @maxime1907. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 27, 2023
@oomichi
Copy link
Contributor

oomichi commented Feb 28, 2023

openssh-client was present before this #9810.

I coud not find a git history which contained openssh-client on the Dockerfile.
I might miss something..

@maxime1907
Copy link
Contributor Author

maxime1907 commented Feb 28, 2023

openssh-client was present before this #9810.

I coud not find a git history which contained openssh-client on the Dockerfile. I might miss something..

@oomichi its because we recently added a flag --no-install-recommends that skips some packages that were previously installed but not directly stated into the Dockerfile.

You can see it happened to others here too:

@oomichi
Copy link
Contributor

oomichi commented Feb 28, 2023

openssh-client was present before this #9810.

I coud not find a git history which contained openssh-client on the Dockerfile. I might miss something..

@oomichi its because we recently added a flag --no-install-recommends that skips some packages that were previously installed but not directly stated into the Dockerfile.

You can see it happened to others here too:

Thank you for your explanation, I see that.

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxime1907, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@oomichi
Copy link
Contributor

oomichi commented Feb 28, 2023

@maxime1907 Could you rebase this pull request to solve a conflict?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2023
@maxime1907
Copy link
Contributor Author

@oomichi done!

@yankay
Copy link
Member

yankay commented Mar 2, 2023

Thanks @maxime1907
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit b7fe368 into kubernetes-sigs:master Mar 2, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
HoKim98 pushed a commit to ulagbulag/kubespray that referenced this pull request Mar 8, 2023
nolimitkun pushed a commit to nolimitkun/kubespray that referenced this pull request Mar 19, 2023
@yankay yankay mentioned this pull request May 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants