feat(contrib/terraform): support custom ssh port #9836
Conversation
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @maxime1907. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
| attrs['ansible_ssh_user'] = raw_attrs['metadata.ssh_user'] | ||
| attrs['ansible_user'] = raw_attrs['metadata.ssh_user'] | ||
| if 'metadata.ssh_port' in raw_attrs: | ||
| attrs['ansible_port'] = raw_attrs['metadata.ssh_port'] |
There was a problem hiding this comment.
Do we still need 'ansible_ssh_port': 22, of line 288?
There was a problem hiding this comment.
nope, it has been removed here #9828
There was a problem hiding this comment.
omg, we have already done :-)
/ok-to-test
/approve
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxime1907, oomichi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Thanks @maxime1907 |
k8s-ci-robot
added
the
lgtm
What type of PR is this?
/kind feature
What this PR does / why we need it:
For security measures, its best to change the default ssh port to something uncommon.
This simple PR adds the possibility to specify a custom ssh port.
Does this PR introduce a user-facing change?: