Update check calico version command

[zhan9san]

What type of PR is this?

/kind bug

What this PR does / why we need it:

The Get current calico cluster version has not ever been working.

And the task fail is ignore, by 'fail_when: false'

TASK [network_plugin/calico : Get current calico cluster version] ********************************************************************************
ok: [node1]

It's Client instead of Cluster

$ /usr/local/bin/calicoctl.sh version
Client Version:    v3.24.5
Git commit:        f1a1611ac
Unable to detect installed Calico version

Which issue(s) this PR fixes:

No issue

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Calico] Improve version check command

[k8s-ci-robot]

Hi @zhan9san. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cyclinder]

/ok-to-test

[cyclinder]

change name to: Get current calico version

[zhan9san]

Thanks for your review.
I'll update it in new commit

[cyclinder]

I think it should be keep here

[zhan9san]

Previously, calico_version_on_server.stdout is always undefined as the check command is wrong.

If the check version is required, the stdout is expected to be an exact version. Otherwise, the assertion would fail.

If we allow/ignore the stdout is undefined, it seems there is no need to check the version anymore.

[cyclinder]

Lines 51-57 should be kept also, Why are they being removed?

[zhan9san]

Thanks for your review.

The run_once: True and delegate_to: "{{ groups['kube_control_plane'][0] }}" is removed by mistake. I'll add them back in new commit.

But for the rest of lines removed, I don't think it should be kept.

In general, the async is for some long tasks, and there is async_status after that to wait to complete.

But we don't use async in that manner. IMO, the check version is a light-weight option, so there is no need to introduce async.

Looking forward to your reply.

[cyclinder]

Thanks for your explanation. The changes in this version look very clean！

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, zhan9san

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mzaian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment