-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add systemd_resolved_disable_stub_listener #9875
Conversation
|
Welcome @cosandr! |
Hi @cosandr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Thanks @cosandr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cosandr Thank you, lgtm to expose this as a user var 👍
Rebased and fixed conflict. |
@floryut Apologies for the ping, is there anything more I need to do here? The pipeline failures don't seem related to this PR (the latest one failed as it ran out of memory for example). |
I've restarted the pipeline there was a CI issue, but unfortunately there is another issue with molecule specific jobs |
Hi @cosandr, sorry for the wait I just noticed your PR now :(. It looks good to me however can you rebase to rekick the pipeline? Thanks 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution :D!
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cosandr, floryut, MrFreezeex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Exposes the option to set
DNSStubListener=no
to the users via a new variable,systemd_resolved_disable_stub_listener
.PR #9160 fixed this issue for Flatcar, but I ran into it on a Rocky Linux 9 VM which was configured to use systemd-resolved. I realize this is not the way the distribution ships, but I don't see anything wrong with exposing this setting to users.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: