Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kube-profile config to the scheduler #9993

Merged

Conversation

yankay
Copy link
Member

@yankay yankay commented Apr 17, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

The kube-profile config is only worked on the kube-apiserver and ccm, but not the kube-scheduler, it's hard to use.
So add the config to the kube-scheduler,

Once the config is added, the hardening guild does not need to change the kube_kubeadm_scheduler_extra_args, because it can be configed using the kube_profiling with kube-apiserver and ccm together.

Which issue(s) this PR fixes:

Fixes #9987

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add the  `kube-profile` config to the kubeadm's  `kube-scheduler` config.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2023
@oomichi
Copy link
Contributor

oomichi commented Apr 18, 2023

Nice work.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit c98e1d1 into kubernetes-sigs:master Apr 18, 2023
@yankay
Copy link
Member Author

yankay commented Apr 18, 2023

Thanks @oomichi :-)

@floryut floryut added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 18, 2023
@yankay yankay mentioned this pull request May 15, 2023
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants