Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AKS deployer #193

Closed
helayoty opened this issue Jun 1, 2022 · 5 comments
Closed

Implement AKS deployer #193

helayoty opened this issue Jun 1, 2022 · 5 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@helayoty
Copy link

helayoty commented Jun 1, 2022

Would be great to have an AKS deployer available in kubetest2. That will help us integrate with e2e-framework as we were discussing here

/help

@k8s-ci-robot
Copy link
Contributor

@helayoty:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Would be great to have an AKS deployer available in kubetest2. That will help us integrate with e2e-framework as we were discussing here

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 1, 2022
@BenTheElder
Copy link
Member

BenTheElder commented Jun 25, 2022

FWIW: see discussion in #190 (comment)

TLDR:
The deployers we have now are meant to be relatively simple, zero dependency (only exec) examples.

kubetest2 is expressly designed to enable implementing more deployers out of tree with tighter integration (e.g. using the EKS or AKS or kops libraries) without the dependency and globals hell we had in kubetest (by keeping them in seperate binaries + modules with seperate dep trees), and with independent maintainers. etc.

kubetest2 operates on a binary plugin model, so external deployers are pretty much on the same level as anything in-tree.
we just need something in tree for developing the project, so we ported some of the most used deployers from the old kubetest

we should probably improve the docs to more clearly emphasize how the project is meant to be extensible out of tree.

also, at the moment, I am the sole active maintainer, and my focus doesn't lie here, so i'm over extended with the currently available features 😞

kops is here:
https://pkg.go.dev/k8s.io/kops/tests/e2e/kubetest2-kops
https://kops.sigs.k8s.io/contributing/testing/#kubernetes-e2e-testing

@spiffxp
Copy link
Member

spiffxp commented Aug 25, 2022

/close
Looks like kubernetes-sigs/cloud-provider-azure#2163 has implemented kubetest2-aks

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
Looks like kubernetes-sigs/cloud-provider-azure#2163 has implemented kubetest2-aks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BenTheElder
Copy link
Member

we should consider pointing to some of these projects from the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants