-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't extract e2e.test and ginkgo binary into artifacts.BaseDir() #97
Comments
location: kubetest2/pkg/testers/ginkgo/package.go Lines 96 to 97 in a964c23
|
I could see both sides here, it might be useful for someone while debugging to know exactly what binary was used. In general, we want to add a way where deployer/testers can choose to distinguish the artifacts used during the run vs the artifacts that the deployer/tests want to upload. |
Agree for somecase it will be helpful to collect as artifacts but in case of downloading or using these binaries from some other repository is very costly, not everyone can afford that default feature. As you mentioned let's think about putting it somewhere else so that artifact does not collect it. |
@amwat: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
These two binaries are extracted under the Artifacts folder and collected post-run and this end up utilizing a lot of space in the GCS which is not required as nothing else is captured, hence it will be good if we can put them into some temp folder and trigger from there
The text was updated successfully, but these errors were encountered: