Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sigs.k8s.io/boskos #207

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Aug 1, 2022

This can potentially fix kubernetes/kubernetes#111584

Ran the following:

$ go get -u sigs.k8s.io/boskos@37bd9bb41b86a849da3e2fa379e5c60d666cb4de
$ make fix

Using kubernetes-sigs/boskos@37bd9bb because that's the last commit of boskos which doesn't pull in k/test-infra code which uses Generics.

Signed-off-by: Nabarun Pal pal.nabarun95@gmail.com

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 1, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 1, 2022
@palnabarun
Copy link
Member Author

Interesting! kubernetes/test-infra@0e771b6 introduces generics. We can't use that here since kubetest2 still uses Go 1.17. Updating Go is a different concern right now.

# k8s.io/test-infra/prow/config/secret
../../../../pkg/mod/k8s.io/test-infra@v0.0.0-20220726093710-8f4d4ce3e334/prow/config/secret/agent.go:73:6: missing function body
../../../../pkg/mod/k8s.io/test-infra@v0.0.0-20220726093710-8f4d4ce3e334/prow/config/secret/agent.go:73:19: syntax error: unexpected [, expecting (
../../../../pkg/mod/k8s.io/test-infra@v0.0.0-20220726093710-8f4d4ce3e334/prow/config/secret/agent.go:111:51: syntax error: unexpected {, expecting comma or )
../../../../pkg/mod/k8s.io/test-infra@v0.0.0-20220726093710-8f4d4ce3e334/prow/config/secret/agent.go:113:22: syntax error: unexpected ] at end of statement
note: module requires Go 1.18 

Trying to find a Boskos version which uses a k/test-infra version before generics were added.

Signed-off-by: Nabarun Pal <pal.nabarun95@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 1, 2022
@palnabarun palnabarun changed the title Update sigs.k8s.io/boskos to latest Update sigs.k8s.io/boskos Aug 1, 2022
@ameukam
Copy link
Member

ameukam commented Aug 1, 2022

/assign @BenTheElder @MushuEE

@dims
Copy link
Member

dims commented Aug 1, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2022
@BenTheElder
Copy link
Member

Using kubernetes-sigs/boskos@37bd9bb because that's the last commit of boskos which doesn't pull in k/test-infra code which uses Generics.

ugh, we really should consider breaking the dependency on test-infra here, that is not a fun repo to have as a dependency :/

thanks for the PR

@BenTheElder
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2022
@palnabarun
Copy link
Member Author

ugh, we really should consider breaking the dependency on test-infra here, that is not a fun repo to have as a dependency :/

I agree. We need to see how we can change that dependency.

@BenTheElder
Copy link
Member

The best answer is probably copying in our own boskos client like @munnerz did in test-infra, boskos client is pretty simple and stable, and the API is not really changing.

I'm going to file a test-infra bug about generics use though, this is problematic given we have kubernetes versions without it yet.

@k8s-ci-robot k8s-ci-robot merged commit 1284e5a into kubernetes-sigs:master Aug 1, 2022
@palnabarun
Copy link
Member Author

I'm going to file a test-infra bug about generics use though, this is problematic given we have kubernetes versions without it yet.

Yes please. Thank you! I was wondering how we got the generics change in. I like the policy you wrote in kubernetes/community#6693 and should ideally want to get it in soon.

@BenTheElder
Copy link
Member

@palnabarun palnabarun deleted the update-boskos branch August 1, 2022 17:07
@palnabarun
Copy link
Member Author

The best answer is probably copying in our own boskos client like @munnerz did in test-infra, boskos client is pretty simple and stable, and the API is not really changing.

I will try to make this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Failing test] Conformance-GCE-master-kubetest2
6 participants