Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NamespaceSelector to ClusterQueue #4

Closed
ahg-g opened this issue Feb 17, 2022 · 6 comments · Fixed by #90
Closed

Add NamespaceSelector to ClusterQueue #4

ahg-g opened this issue Feb 17, 2022 · 6 comments · Fixed by #90
Assignees
@ahg-g
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Feb 17, 2022

NamespaceSelector in capacity allows controlling which namespaces are allowed to use the capacity.

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 17, 2022
@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 18, 2022

/size M

@ahg-g ahg-g added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 18, 2022
@denkensk
Copy link
Member

Does is mean we need a validating webhook?

@ahg-g
Copy link
Contributor Author

ahg-g commented Feb 19, 2022 •
edited

Does is mean we need a validating webhook?

No not a webhook, kueue itself should not consider assigning capacity to queue in not selected namespcaes. We also need to produce events and perhaps update queue status to indicate whether the capacity a queue is pointing to is allowed.

@jiwq
Copy link
Contributor

jiwq commented Feb 23, 2022

/assign

@ahg-g ahg-g mentioned this issue Mar 2, 2022
Closed
14 tasks
@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 2, 2022

/unassign @jiwq
/assign

we need to do this soon, @jiwq please feel free to pick other issues when you have time.

@k8s-ci-robot k8s-ci-robot assigned ahg-g and unassigned jiwq Mar 2, 2022
@ahg-g ahg-g mentioned this issue Mar 3, 2022
Merged
@jiwq
Copy link
Contributor

jiwq commented Mar 7, 2022

@ahg-g Sorry to the late response. I'll continue other work when I have time and submit ASAP. Thanks for your help!

@ahg-g ahg-g changed the title Add NamespaceSelector to Capacity Add NamespaceSelector to ClusterQueue Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ahg-g ahg-g

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NamespaceSelector for ClusterQueue ahg-g/kueue
4 participants
@jiwq @denkensk @k8s-ci-robot @ahg-g