Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins/plugin-client-common): improved SequenceDiagram view #5343

Merged
merged 1 commit into from Aug 12, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Aug 12, 2020

Fixes #5342

Description of what you did:

My PR is a:

  • 馃挜 Breaking change
  • 馃悰 Bug fix
  • 馃拝 Enhancement
  • 馃殌 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented Aug 12, 2020

Codecov Report

Merging #5343 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5343      +/-   ##
==========================================
- Coverage   59.15%   59.04%   -0.12%     
==========================================
  Files          78       78              
  Lines        2544     2544              
  Branches      629      629              
==========================================
- Hits         1505     1502       -3     
- Misses        794      797       +3     
  Partials      245      245              
Impacted Files Coverage 螖
packages/core/src/core/userdata.ts 63.88% <0.00%> (-4.17%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ea21221...76604ef. Read the comment docs.

@starpit starpit merged commit 1e2fb41 into kubernetes-sigs:master Aug 12, 2020
@starpit starpit deleted the fix-5342 branch August 12, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

follow up: implement improved SequenceDiagram
1 participant