Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-client-common): split header tooltips have odd spa… #8721

Merged
merged 1 commit into from
Feb 27, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default class SplitHeader extends React.PureComponent<Props> {
private closeButton() {
return (
this.props.onRemove && (
<Tooltip markdown={strings('Close this split pane')}>
<Tooltip content={strings('Close this split pane')} position="bottom-end">
<a
href="#"
className="kui--split-close-button kui--tab-navigatable kui--split-header-button"
Expand Down Expand Up @@ -92,7 +92,7 @@ export default class SplitHeader extends React.PureComponent<Props> {
private splitPositionToggleButton() {
return (
this.props.willToggleSplitPosition && (
<Tooltip markdown={strings('Toggle position')}>
<Tooltip content={strings('Toggle position')} position="bottom-end">
<a
href="#"
className="kui--tab-navigatable"
Expand All @@ -111,7 +111,7 @@ export default class SplitHeader extends React.PureComponent<Props> {

private invertButton() {
return (
<Tooltip markdown={strings('Invert colors')}>
<Tooltip content={strings('Invert colors')} position="bottom-end">
<a href="#" className="kui--tab-navigatable" onMouseDown={this.stopFocusStealing} onClick={this.props.onInvert}>
<Icons className="kui--split-invert-button kui--split-header-button" icon="Contrast" />
</a>
Expand All @@ -121,7 +121,7 @@ export default class SplitHeader extends React.PureComponent<Props> {

private clearButton() {
return (
<Tooltip markdown={strings('Clear this split pane')}>
<Tooltip content={strings('Clear this split pane')} position="bottom-end">
<a href="#" className="kui--tab-navigatable" onMouseDown={this.stopFocusStealing} onClick={this.props.onClear}>
<Icons className="kui--split-clear-button kui--split-header-button" icon="Clear" />
</a>
Expand Down