Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution: this introduces some breaking changes in the xterm API. Nothing at the Kui level has changed, but if other plugins are assuming the
xterm
npm comes in via kui, they may encounter breaking changes.This PR also introduces the use of the webgl renderer for the kubectl Terminal and Logs tabs.
Description of what you did:
My PR is a:
Please confirm that your PR fulfills these requirements
fix(plugins/plugin-k8s): fixed annoying bugs