Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use dl.k8s.io, not kubernetes-release bucket #9360

Merged
merged 1 commit into from
May 17, 2023

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented May 12, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

There are still references to https://storage.googleapis.com/kubernetes-release instead of https://dl.k8s.io/

dl.k8s.io is the correct advertised download host and will eventually move to be fastly shielding a fully community-owned bucket

ref: kubernetes/k8s.io#2396

Required Items

  • Your PR consists of a single commit (i.e. squash your commits)
  • Your commit and PR title starts with one of fix: | test: | chore: | doc:, to indicate the nature of the fix (see Conventional Commits)

Optional Items

  • 💥 This PR involves a breaking change. If so, include "BREAKING CHANGE: ...why..." in the commit and PR message.

Signed-off-by: Ricky Sadowski <richard.j.sadowski@gmail.com>
@rjsadow rjsadow requested a review from starpit as a code owner May 12, 2023 00:52
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 12, 2023
@k8s-ci-robot k8s-ci-robot requested a review from mark-nc May 12, 2023 00:52
@rjsadow
Copy link
Contributor Author

rjsadow commented May 12, 2023

/retest

2 similar comments
@rjsadow
Copy link
Contributor Author

rjsadow commented May 16, 2023

/retest

@Namanl2001
Copy link
Member

/retest

@starpit
Copy link
Contributor

starpit commented May 17, 2023

thanks for doing this!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2023
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjsadow, starpit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7ff787d into kubernetes-sigs:master May 17, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants