add rnode test

api/filters/namespace/example_test.go

@@ -40,11 +40,11 @@ metadata:
 	// kind: Foo
 	// metadata:
 	//   name: instance
-	//   namespace: 01234
+	//   namespace: "01234"
 	// ---
 	// apiVersion: example.com/v1
 	// kind: Bar
 	// metadata:
 	//   name: instance
-	//   namespace: 01234
+	//   namespace: "01234"
 }

api/filters/namespace/namespace_test.go

@@ -302,13 +302,13 @@ apiVersion: example.com/v1
 kind: Foo
 metadata:
   name: instance
-  namespace: 01234
+  namespace: "01234"
 ---
 apiVersion: example.com/v1
 kind: Bar
 metadata:
   name: instance
-  namespace: 01234
+  namespace: "01234"
 `,
 		filter: namespace.Filter{Namespace: "01234"},
 	},

kyaml/yaml/rnode_test.go

@@ -1081,15 +1081,29 @@ const deploymentJSON = `
 `
 
 func TestRNodeSetNamespace(t *testing.T) {
-	n := NewRNode(nil)
-	assert.Equal(t, "", n.GetNamespace())
-	assert.NoError(t, n.SetNamespace(""))
-	assert.Equal(t, "", n.GetNamespace())
-	if err := n.UnmarshalJSON([]byte(deploymentJSON)); err != nil {
-		t.Fatalf("unexpected unmarshaljson err: %v", err)
+	testCases := map[string]struct {
+		ns string
+	}{
+		"simple": {
+			ns: "flanders",
+		},
+		"numeric": {
+			ns: "01234",
+		},
+	}
+	for n, tc := range testCases {
+		t.Run(n, func(t *testing.T) {
+			n := NewRNode(nil)
+			assert.Equal(t, "", n.GetNamespace())
+			assert.NoError(t, n.SetNamespace(""))
+			assert.Equal(t, "", n.GetNamespace())
+			if err := n.UnmarshalJSON([]byte(deploymentJSON)); err != nil {
+				t.Fatalf("unexpected unmarshaljson err: %v", err)
+			}
+			assert.NoError(t, n.SetNamespace(tc.ns))
+			assert.Equal(t, tc.ns, n.GetNamespace())
+		})
 	}
-	assert.NoError(t, n.SetNamespace("flanders"))
-	assert.Equal(t, "flanders", n.GetNamespace())
 }
 
 func TestRNodeSetLabels(t *testing.T) {
@@ -1805,16 +1819,30 @@ func TestSetName(t *testing.T) {
 }
 
 func TestSetNamespace(t *testing.T) {
-	rn := NewRNode(nil)
-	if err := rn.UnmarshalJSON([]byte(deploymentBiggerJson)); err != nil {
-		t.Fatalf("unexpected unmarshaljson err: %v", err)
+	testCases := map[string]struct {
+		ns string
+	}{
+		"simple": {
+			ns: "flanders",
+		},
+		"numeric": {
+			ns: "01234",
+		},
 	}
-	err := rn.SetNamespace("flanders")
-	require.NoError(t, err)
-	meta, err := rn.GetMeta()
-	require.NoError(t, err)
-	if expected, actual := "flanders", meta.Namespace; expected != actual {
-		t.Fatalf("expected '%s', got '%s'", expected, actual)
+	for n, tc := range testCases {
+		t.Run(n, func(t *testing.T) {
+			rn := NewRNode(nil)
+			if err := rn.UnmarshalJSON([]byte(deploymentBiggerJson)); err != nil {
+				t.Fatalf("unexpected unmarshaljson err: %v", err)
+			}
+			err := rn.SetNamespace(tc.ns)
+			require.NoError(t, err)
+			meta, err := rn.GetMeta()
+			require.NoError(t, err)
+			if expected, actual := tc.ns, meta.Namespace; expected != actual {
+				t.Fatalf("expected '%s', got '%s'", expected, actual)
+			}
+		})
 	}
 }