fix from review comments

kubernetes-sigs · Aug 2, 2022 · 90231f4 · 90231f4
1 parent c051a2c
commit 90231f4
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/api/types/kustomization.go b/api/types/kustomization.go
@@ -173,10 +173,10 @@ type Kustomization struct {
 }
 
 const (
-	deprecatedBaseWarningMessage           = "# Warning: bases was deprecated, Please use resources or try `kustomize edit fix`."
-	deprecatedPatchesJson6902Message       = "# Warning: patchesJson6902 is deprecated, Please use patches or try `kustomize edit fix`."
-	deprecatedPatchesStrategicMergeMessage = "# Warning: bases is patchesStrategicMerge, Please use patches or try `kustomize edit fix`."
-	deprecatedVarsMessage                  = "# Warning: vars is deprecated, Please use replacements."
+	deprecatedBaseWarningMessage           = "# Warning: bases was deprecated, Please use 'resources' or try `kustomize edit fix`."
+	deprecatedPatchesJson6902Message       = "# Warning: patchesJson6902 is deprecated, Please use 'patches' or try `kustomize edit fix`."
+	deprecatedPatchesStrategicMergeMessage = "# Warning: patchesStrategicMerge is deprecated, Please use 'patches'."
+	deprecatedVarsMessage                  = "# Warning: vars is deprecated, Please use 'replacements'."
 )
 
 // CheckDeprecatedFields check deprecated field is used or not.

diff --git a/api/types/kustomization_test.go b/api/types/kustomization_test.go
@@ -22,7 +22,6 @@ func TestKustomization_CheckDeprecatedFields(t *testing.T) {
 		k    Kustomization
 		want *[]string
 	}{
-		// TODO: Add test cases.
 		{
 			name: "using_bases",
 			k: Kustomization{

diff --git a/plugin/builtin/namespacetransformer/go.mod b/plugin/builtin/namespacetransformer/go.mod
@@ -4,6 +4,7 @@ go 1.18
 
 require (
 	sigs.k8s.io/kustomize/api v0.11.5
+	sigs.k8s.io/kustomize/kyaml v0.13.7
 	sigs.k8s.io/yaml v1.2.0
 )
 
@@ -32,5 +33,4 @@ require (
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 	gopkg.in/yaml.v3 v3.0.0-20210107192922-496545a6307b // indirect
 	k8s.io/kube-openapi v0.0.0-20220401212409-b28bf2818661 // indirect
-	sigs.k8s.io/kustomize/kyaml v0.13.7 // indirect
 )