fix: goroutine leak

api/internal/utils/timedcall.go

@@ -10,7 +10,7 @@ import (
 // TimedCall runs fn, failing if it doesn't complete in the given duration.
 // The description is used in the timeout error message.
 func TimedCall(description string, d time.Duration, fn func() error) error {
-	done := make(chan error)
+	done := make(chan error, 1)
 	timer := time.NewTimer(d)
 	defer timer.Stop()
 	go func() { done <- fn() }()

api/internal/utils/timedcall_test.go

@@ -5,6 +5,7 @@ package utils_test
 
 import (
 	"fmt"
+	"runtime"
 	"testing"
 	"time"
 
@@ -62,3 +63,15 @@ func TestTimedCallSlowWithError(t *testing.T) {
 		t.Fail()
 	}
 }
+
+func TestTimedCallGoroutineLeak(t *testing.T) {
+	beforeGroutine := runtime.NumGoroutine()
+	_ = TimedCall("expect no goroutine leaks", time.Duration(time.Second), func() error {
+		time.Sleep(2 * time.Second)
+		return fmt.Errorf("not done")
+	})
+	afterGoroutine := runtime.NumGoroutine()
+	if beforeGroutine != afterGoroutine {
+		t.Fatal("goroutine leak")
+	}
+}