Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to allow more general name, kind, namespace changing #3280

Closed
4 tasks done
natasha41575 opened this issue Nov 25, 2020 · 4 comments
Closed
4 tasks done

Refactor to allow more general name, kind, namespace changing #3280

natasha41575 opened this issue Nov 25, 2020 · 4 comments
Labels
area/api issues for api module kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@natasha41575
Copy link
Contributor

natasha41575 commented Nov 25, 2020 •
edited
Loading

After updating the GVKN/Ns, you should still be able to refer to the resource by either its original GVKN/Ns or the current one.

  • Add tests
  • Refactor PrefixSuffixTransformer and NameReferenceTransformer to use yaml annotations
  • Refactor namespace changing to use yaml annotations
  • Allow name/kind changing via a patch
@natasha41575
Copy link
Contributor Author

@Shell32-Natsu this is "in progress", thank you

@Shell32-Natsu Shell32-Natsu added area/api issues for api module kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Nov 30, 2020
@natasha41575 natasha41575 mentioned this issue Dec 1, 2020
Merged
@Shell32-Natsu Shell32-Natsu mentioned this issue Dec 14, 2020
Closed
@natasha41575 natasha41575 mentioned this issue Dec 17, 2020
Merged
@Shell32-Natsu Shell32-Natsu mentioned this issue Jan 5, 2021
Open
@Shell32-Natsu
Copy link
Contributor

@natasha41575 @monopole Do we have plan to support referring resource by a intermediate name instead of either current or original name? Requested in #3228

@Shell32-Natsu Shell32-Natsu mentioned this issue Jan 11, 2021
Closed
@natasha41575
Copy link
Contributor Author

@Shell32-Natsu if we want to support that, then I can implement that after this refactoring is complete

@Shell32-Natsu
Copy link
Contributor

@natasha41575 Thanks! It will be great to support it. And you may need to consider it when you refactor the NameReferenceTransformer

@natasha41575 natasha41575 mentioned this issue Jan 11, 2021
Closed
@natasha41575 natasha41575 mentioned this issue Feb 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api issues for api module kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shell32-Natsu @natasha41575