Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to Use replacements for Boolean Fields #4479

Closed
GuyPaddock opened this issue Feb 19, 2022 · 2 comments
Closed

Ability to Use replacements for Boolean Fields #4479

GuyPaddock opened this issue Feb 19, 2022 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@GuyPaddock
Copy link

Problem

ConfigMaps can only contain strings, but fields like readOnly in container volume mounts are strictly required to be booleans. At present, it does not appear to be possible to replace a boolean value or to convert a string to a boolean during replacement.

Desired Solution

Add a way for replacements to coerce a string into the appropriate target data type.

Alternatives

Perhaps a transformer that can convert a transformed value into the proper data type.
@GuyPaddock GuyPaddock added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 19, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 19, 2022
GuyPaddock added a commit to Inveniem/nextcloud-azure-aks that referenced this issue Mar 6, 2022
@GuyPaddock
[ITSA-706] Abandon Using ConfigMap for Read-only Config Volume
bd7fa11 
- The `replacements` feature of Kustomize can only source values from a
  `ConfigMap`.
- A `ConfigMap` can only contain strings.
- The `readOnly` value of a mount has to be a boolean.

A fix for this limitation has been requested as:
kubernetes-sigs/kustomize#4479

In the meantime, it does not look like we'll be able to drive the volume
mount setting off a `ConfigMap`, so we'll just have to document that
admins will need to set this in the `configure-storage.nextcloud.yaml`
file.
@natasha41575
Copy link
Contributor

I believe #4494 will do what you are describing.

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 7, 2022
@lack lack mentioned this issue Mar 17, 2022
Merged
@KnVerey
Copy link
Contributor

KnVerey commented Mar 17, 2022

Closed by #4494 (see this test: https://github.com/kubernetes-sigs/kustomize/pull/4494/files#diff-909c0819f13e268a60555f0aa78bd8acdbb42c10f3e2a906d62ba4b9d1722947R2065)

@KnVerey KnVerey closed this as completed Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@GuyPaddock @KnVerey @natasha41575 @k8s-ci-robot