-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error handling for connectivity issues to github remote sources #5382
Comments
This issue is currently awaiting triage. SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I ran into the same problem and have been digging into the code to see how best to fix it. The code around loading resources is a bit of a mess and it doesn't look like it's going to be an easy fix. The problem comes from this section of the code: kustomize/api/internal/target/kusttarget.go Lines 420 to 433 in 0122aa8
My interpretation of this logic is:
The problem here is that the HTTP SummaryAll of the problems seem to come down to trying to load resources by optimistically fetching both the HTTP content and trying to fetch it with git. That may kind of work most of the time for the happy path, but what do you do if both of these fail? When the user specified a resource starting with |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
Eschewed features
What would you like to have added?
Currently, kustomize build running with github remote sources is not providing clear information when the git commands fails or did not get the expected content. We end up with error message like this one: MalformedYAMLError: yaml: line 30: mapping values are not allowed in this context in File which are not easy to understand. I would also suggest adding some retry mecanism depending on the type of error we get from git.
Why is this needed?
Having proper git command handling for all types of failures will help end user to troubleshoot issues.
Can you accomplish the motivating task without this feature, and if so, how?
We could probably enable git debugging locally but those logs can be huge and would collect all the git commands on the system. not just the one from kustomize build.
What other solutions have you considered?
N/A
Anything else we should know?
N/A
Feature ownership
The text was updated successfully, but these errors were encountered: