fix: handle empty namespace as default #5430
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/kind bug |
stormqueen1990
force-pushed
the
fix/treat-empty-ns-as-default-ns
branch
from
b09fa07
to
894bf8a
Compare
|
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm Thanks for the fix, code changes LGTM. Please ping me for approval once you confirm from @ncapps's comment above if the go.work.sum file is correctly updated |
k8s-ci-robot
added
the
lgtm
Update the namespace handling in the edit add configmap and secret commands to handle the empty namespace and the default namespace in the same way. Before this change, if a configmap/secret was created using kustomize edit add where one command was issued with default as the namespace and the other without a namespace specified it would create two separate configmap generators, and then kustomize build would fail if merge was not the strategy for either.
Run go mod tidy to remove references of golang.org/x/exp, that was used during development but later removed.
stormqueen1990
force-pushed
the
fix/treat-empty-ns-as-default-ns
branch
from
6a95c1d
to
73c9875
Compare
k8s-ci-robot
removed
the
lgtm
I've undone the changes to |
stormqueen1990
force-pushed
the
fix/treat-empty-ns-as-default-ns
branch
from
08b0f69
to
623f963
Compare
stormqueen1990
force-pushed
the
fix/treat-empty-ns-as-default-ns
branch
from
8a4cd19
to
623f963
Compare
Revert changes made to go.work.sum, since they don't pertain to code changed in this PR.
stormqueen1990
force-pushed
the
fix/treat-empty-ns-as-default-ns
branch
from
623f963
to
4d7b8ef
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, stormqueen1990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Changes
Update the namespace handling in the
edit add configmap/edit add secretcommands to handle the empty namespace as ifdefaultwas specified.Before this change, if
configMapGenerators/secretGeneratorswere created usingkustomize edit addwhere one command was issued withdefaultas the namespace and another without a namespace specified, Kustomize created two separateconfigMapGenerators/secretGenerators, and then failed duringkustomize buildif the strategy didn't merge both.