feat: edit set configmap #5391
Merged
feat: edit set configmap #5391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has multiple commits, and the default merge method is: merge. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XL
kustomize/commands/internal/util/configmapSecretFlagsAndArgs.go
Outdated
Show resolved
Hide resolved
stormqueen1990
force-pushed
the
feat/edit-set-configmap
branch
from
28830c4
to
e0cb8d8
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
stormqueen1990
force-pushed
the
feat/edit-set-configmap
branch
from
e0cb8d8
to
5381f37
Compare
ncapps
reviewed
Oct 27, 2023
kustomize/commands/internal/util/configmapSecretFlagsAndArgs_test.go
Outdated
Show resolved
Hide resolved
stormqueen1990
force-pushed
the
feat/edit-set-configmap
branch
from
b93aea8
to
4ec1a7a
Compare
k8s-ci-robot
added
size/XL
Hi @ncapps! Yes, that's correct. I intend to add |
stormqueen1990
force-pushed
the
feat/edit-set-configmap
branch
from
15b25c6
to
48a1c07
Compare
k8s-ci-robot
added
the
lgtm
|
I am not an official reviewer but these changes lgtm. |
There was a problem hiding this comment.
@stormqueen1990 Thanks for the PR. My reviews are just language specific nits. The general logic seems good :)
/lgtm
kustomize/commands/internal/util/configmapSecretFlagsAndArgs.go
Outdated
Show resolved
Hide resolved
kustomize/commands/internal/util/configmapSecretFlagsAndArgs.go
Outdated
Show resolved
Hide resolved
k8s-ci-robot
removed
the
lgtm
stormqueen1990
force-pushed
the
feat/edit-set-configmap
branch
from
b03384c
to
b074890
Compare
k8s-ci-robot
added
the
needs-rebase
natasha41575
reviewed
Nov 2, 2023
k8s-ci-robot
added
the
do-not-merge/hold
stormqueen1990
force-pushed
the
feat/edit-set-configmap
branch
from
a368f9f
to
d74bb63
Compare
k8s-ci-robot
removed
lgtm
stormqueen1990
force-pushed
the
feat/edit-set-configmap
branch
from
d74bb63
to
bf3326a
Compare
9 tasks
* Add a new command 'edit set configmap' to allow editing the values of an already-existing configmap in a kustomization file. * Add tests to validate the new feature.
* Include tests to validade the new function ValidateSet, included to do necessary validations when running the 'kustomize edit set configmap' command. * Minor refactorings to use the existing constants in the 'edit set configmap' command. * Add dashes before each item in the comment explaining how ExpandFileSource() works so IDEs don't try to reformat the list and remove the indentation in it. * Because this change mutates the list of literal sources, ensure that both add and set save the resulting list in a predictable order to make it easier to check when new items are added/removed and aid in testing. * Since literal sources are the only bit that's important in this test, verify that the literal sources in the actual result is equal to what we expected it to be.
Use '%q' formatter instead of '%s' to print resource name Co-authored-by: Varsha <varshaprasad96@gmail.com>
* Unexport constant that is used only in the scope of a single function. * Add extra validation to ensure format is correct with one single '=' per key-value pair. * Add extra set of tests to validate format. * Update test case to match new printed format in the error message.
Rename the test package from set_test back to set and unexport functions that do not need to be exported anymore for testing purposes.
Handle the empty and the default namespaces as equal. Add tests to validate this scenario.
stormqueen1990
force-pushed
the
feat/edit-set-configmap
branch
from
bf3326a
to
de2dcaf
Compare
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
stormqueen1990
requested review from
ncapps,
natasha41575 and
charles-chenzz
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, stormqueen1990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at implementing the
edit set configmapcommand. Initally adding just two flags:--from-literaland--new-namespace.Related issue: #4493