Unexpected json-patch dependency version

[howardjohn]

In #5197, a dep on gopkg.in/evanphx/json-patch.v5 was added. This linked kubernetes/kubernetes#118384 as rationale, which added a dep on github.com/evanphx/json-patch/v5. Later, kubernetes/kubernetes#120327 reverted the #118384.

There are two concerns:

• If the reason to bump to v5 was to follow k/k, then given k/k reverted the change this may need to be re-evaluated
• gopkg.in/evanphx/json-patch.v5 is used instead of github.com/evanphx/json-patch/v5, which differs from the rest of the kubernetes ecosystem and results in duplicate imports.

cc @skitt

[k8s-ci-robot]

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[skitt]

I agree #5197 should be reverted. Regarding the latter point, gopkg.in is the documented import, so I think that’s what should be used.