Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for patch files hosted in git repos #5517

Open
jesse-fabric opened this issue Jan 23, 2024 · 3 comments
Open

Support for patch files hosted in git repos #5517

jesse-fabric opened this issue Jan 23, 2024 · 3 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jesse-fabric
Copy link

It seems as though the patches stanza does not support yaml files stored in git repos currently. It would be very helpful if it did, similar to the resources stanza.

In resources, you can do something similar to the following to load up kustomizations from a git repo:

resources:
- ssh://git@github.com/org/repo/path/to/kustomization/dir

The above works for private repos too, as long as you have valid SSH creds locally. It would be great if we could do something similar for patches, such as:

patches:
- path: ssh://git@github.com/org/repo/path/to/patch.yaml

The use-case for my organization is we have a gitops repo that stores patch yaml files with the current image versions, and we would like to be able to use the remote git files from that repo as patches to ensure we stay in sync with what's current when running kustomize.

Any guidance or feedback would be super helpful, thanks!

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG CLI takes a lead on issue triage for this repo, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@grubitwo
Copy link

grubitwo commented Mar 8, 2024

It would be great if we could do something like that too similar for replacements, such as:

replacements:
- path: ssh://git@github.com/org/repo/path/to/replacements.yaml

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants