Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin golint score at 100% #69

Closed
monopole opened this issue Jun 8, 2018 · 2 comments
Closed

Pin golint score at 100% #69

monopole opened this issue Jun 8, 2018 · 2 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@monopole
Copy link
Contributor

monopole commented Jun 8, 2018

See score here:

https://goreportcard.com/report/github.com/kubernetes-sigs/kustomize#golint

Lets get it up to 100%, then add a test to the pre-commit

https://github.com/kubernetes-sigs/kustomize/blob/master/bin/pre-commit.sh

that fails if it drops below 100%
@monopole monopole added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Jun 8, 2018
@uthark uthark mentioned this issue Jun 10, 2018
Merged
@uthark
Copy link
Contributor

uthark commented Jun 10, 2018 •
edited

Hi! Please take a look at pull request.

@monopole
Copy link
Contributor Author

fixed by #77

@snyk-bot snyk-bot mentioned this issue Jun 2, 2020
Open
@ssmbct-netops ssmbct-netops mentioned this issue Sep 27, 2022
Open
@omerhasan omerhasan mentioned this issue Oct 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@uthark @monopole