Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go lint error and add golint checks to a pre-commit hook #77

Merged
merged 1 commit into from
Jun 10, 2018
Merged

Fix go lint error and add golint checks to a pre-commit hook #77

merged 1 commit into from
Jun 10, 2018

Conversation

uthark
Copy link
Contributor

@uthark uthark commented Jun 10, 2018

Pull request for #69

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 10, 2018
monopole
monopole reviewed Jun 10, 2018
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks for the cleanup!

@monopole monopole merged commit 71b7e07 into kubernetes-sigs:master Jun 10, 2018
@monopole monopole mentioned this pull request Jun 10, 2018
Closed
@uthark uthark deleted the golint branch June 11, 2018 01:53
@snyk-bot snyk-bot mentioned this pull request Jun 2, 2020
Open
@ssmbct-netops ssmbct-netops mentioned this pull request Sep 27, 2022
Open
@omerhasan omerhasan mentioned this pull request Oct 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monopole monopole monopole left review comments

@mengqiy mengqiy Awaiting requested review from mengqiy

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uthark @monopole @k8s-ci-robot