-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove inventory transformer #2421
Remove inventory transformer #2421
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @Shell32-Natsu! |
Hi @Shell32-Natsu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Shell32-Natsu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Signed CLA |
Retry |
I signed it |
You may need to change the author for the commits |
The email address is correct in the commits.
|
I guess I need to click the "signup to contribute" link again on this page |
Well that works. |
96f9072
to
9195f05
Compare
This sign up flow could use some improvement :P /lgtm Special thanks to @Liujingfang1 for implementing this design, as it greatly informed the approach being built into client side apply. |
Thanks! |
This field has not done anything since v3.5.5. It was missed in the cleanup in kubernetes-sigs#2421
This field has not done anything since v3.5.5. It was missed in the cleanup in kubernetes-sigs#2421
This field has not done anything since v3.5.5. It was missed in the cleanup in kubernetes-sigs#2421
Remove inventory and update related documentations.