Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inventory transformer #2421

Merged
merged 2 commits into from
Apr 29, 2020

Conversation

Shell32-Natsu
Copy link
Contributor

@Shell32-Natsu Shell32-Natsu commented Apr 27, 2020

Remove inventory and update related documentations.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 27, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @Shell32-Natsu!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Shell32-Natsu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Shell32-Natsu
To complete the pull request process, please assign mortent
You can assign the PR to them by writing /assign @mortent in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 27, 2020
@monopole
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2020
@Shell32-Natsu
Copy link
Contributor Author

Signed CLA

@Shell32-Natsu
Copy link
Contributor Author

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Retry

@Shell32-Natsu
Copy link
Contributor Author

I signed it

@Liujingfang1
Copy link
Contributor

You may need to change the author for the commits
git commit --amend --author="Author Name <email@address.com>"

@Shell32-Natsu
Copy link
Contributor Author

The email address is correct in the commits.

commit 96f907209ee442896f10630ea0f7f11866e9302f (HEAD -> 2392-codeClean, origin/2392-codeClean)
Author: Donny Xia <donnyxia@google.com>
Date:   Mon Apr 27 11:32:10 2020 -0700

    Update document

commit 515ad0a9538f73ea80a47e08b43b4a552151faf1
Author: Donny Xia <donnyxia@google.com>
Date:   Wed Apr 22 16:56:16 2020 -0700

    Remove inventory transformer #2392

@Shell32-Natsu
Copy link
Contributor Author

I guess I need to click the "signup to contribute" link again on this page

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 27, 2020
@Shell32-Natsu
Copy link
Contributor Author

Well that works.

@monopole
Copy link
Contributor

This sign up flow could use some improvement :P

/lgtm

Special thanks to @Liujingfang1 for implementing this design, as it greatly informed the approach being built into client side apply.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 29, 2020
@monopole monopole requested review from monopole and removed request for droot April 29, 2020 18:02
@monopole monopole changed the title #2392 Remove inventory Remove inventory transformer Apr 29, 2020
@monopole monopole merged commit d67c03a into kubernetes-sigs:master Apr 29, 2020
@Shell32-Natsu Shell32-Natsu deleted the 2392-codeClean branch April 29, 2020 18:09
@Shell32-Natsu
Copy link
Contributor Author

Thanks!

KnVerey added a commit to KnVerey/kustomize that referenced this pull request Jan 11, 2023
This field has not done anything since v3.5.5. It was missed in the cleanup in kubernetes-sigs#2421
KnVerey added a commit to KnVerey/kustomize that referenced this pull request Jan 11, 2023
This field has not done anything since v3.5.5. It was missed in the cleanup in kubernetes-sigs#2421
KnVerey added a commit to KnVerey/kustomize that referenced this pull request Jan 13, 2023
This field has not done anything since v3.5.5. It was missed in the cleanup in kubernetes-sigs#2421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants