Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove live; done testing. Bring to sig-cli for discussion. #2976

Merged
merged 1 commit into from Sep 14, 2020
Merged

Remove live; done testing. Bring to sig-cli for discussion. #2976

merged 1 commit into from Sep 14, 2020

Conversation

monopole
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2020
@monopole monopole requested review from seans3 and removed request for mortent and Shell32-Natsu September 14, 2020 17:09
seans3
seans3 approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@seans3 seans3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole, seans3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@monopole monopole merged commit 6a0a909 into kubernetes-sigs:master Sep 14, 2020
@monopole monopole deleted the deferLive branch September 16, 2020 00:31
@Shell32-Natsu Shell32-Natsu mentioned this pull request Sep 16, 2020
Closed
@blaggacao
Copy link

blaggacao commented Sep 16, 2020 •
edited

glad it's monopole:deferLive and not monopole:terminateLive 😜

By the way, does it use kpt libraries as the functionality seemed suspiciously overlapping?

@aodinokov
Copy link
Contributor

By the way, does it use kpt libraries as the functionality seemed suspiciously overlapping?

@blaggacao, it's cli-utils that is used by both kpt and kustomize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seans3 seans3 seans3 approved these changes

Assignees

@seans3 seans3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@monopole @k8s-ci-robot @blaggacao @aodinokov @seans3