-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored resource to store all previous names and namespaces #3525
Refactored resource to store all previous names and namespaces #3525
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much, i really like this PR.
Some minor nits.
Also, I'd appreciate it if you could lgtm #3528 first, and merge that into this.
It's sensitive to name and namespace stuff. It works - i added more tests
before the refactor, and it's all passing.
So if you can merge it before this change i'd appreciate it.
Then i'll take this, and add a fix for #3489 on top of it.
f528fd8
to
43157f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole, natasha41575 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Some resource refactoring to store intermediate names. Reference to #3493 and #3455. A future PR will refactor name reference transformer to remove more of the prefix/suffix logic from the resource code.
Removed:
Resource
Resmap
Added:
Resource
Resmap