Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks to measure impact of swagger parsing #3669

Merged
merged 1 commit into from Mar 5, 2021
Merged

Add benchmarks to measure impact of swagger parsing #3669

merged 1 commit into from Mar 5, 2021

Conversation

justinsb
Copy link
Contributor

@justinsb justinsb commented Mar 3, 2021 •
edited

Example results:

BenchmarkSwaggerUnmarshalJSON-72               2         894038320 ns/op
BenchmarkAssetRead-72                         61          19698938 ns/op

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 3, 2021
@justinsb justinsb mentioned this pull request Mar 3, 2021
Closed
@justinsb
Copy link
Contributor Author

justinsb commented Mar 3, 2021

Please see discussion in #3670 - the issue is more important than merging the benchmarks :-)

@justinsb
Add benchmarks to measure impact of swagger parsing
8e57ee9 
Example results:

BenchmarkSwaggerParse-72               2         882910241 ns/op
BenchmarkAsssetUnpack-72              62          19654866 ns/op
@monopole
Copy link
Contributor

monopole commented Mar 4, 2021

Thanks Justin, we need many more of these.

monopole
monopole approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, monopole

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a1df3e0 into kubernetes-sigs:master Mar 5, 2021
@apelisse
Copy link

Note that kubectl downloads the protobuf version of the openapi from the kube-apiserver because it's much faster to decode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monopole monopole monopole approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@monopole monopole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@justinsb @monopole @k8s-ci-robot @apelisse