-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to set target namespace for helm chart template #3832
Add ability to set target namespace for helm chart template #3832
Conversation
Welcome @cehoffman! |
Hi @cehoffman. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
Thanks, especially for the nice job of updating a real test. however, before we add a bunch of helm flag and argument pass thru, we need to consider how far to go. See #3815 (comment) |
/lgtm |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
We can ponder a better integration with the NamespaceTransformer as a separate issue.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cehoffman, monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #3815
Finding a chart to test with took a bit, but this is from the British Columbia government.