Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exclude statements #4387

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Remove exclude statements #4387

merged 1 commit into from
Feb 7, 2022

Conversation

Neo2308
Copy link
Contributor

@Neo2308 Neo2308 commented Jan 14, 2022

Removed exclude statements from go mod file.
Addresses #3618

@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

Welcome @Neo2308!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 14, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Neo2308. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2022
@linux-foundation-easycla
Copy link

CLA Not Signed

1 similar comment
@linux-foundation-easycla
Copy link

CLA Not Signed

@Neo2308
Copy link
Contributor Author

Neo2308 commented Jan 14, 2022

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 14, 2022
@KnVerey
Copy link
Contributor

KnVerey commented Jan 26, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2022
@CecileRobertMichon CecileRobertMichon mentioned this pull request Jan 26, 2022
Merged
@kaitoii11 kaitoii11 mentioned this pull request Jan 27, 2022
Closed
@KnVerey
Copy link
Contributor

KnVerey commented Feb 2, 2022

/approve

Can you rebase please?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, Neo2308

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 2, 2022
@Neo2308
Copy link
Contributor Author

Neo2308 commented Feb 6, 2022

Is there a need to rebase? This PR doesn't have merge conflicts.

@KnVerey
Copy link
Contributor

KnVerey commented Feb 7, 2022

The bot that controls merging was saying it did, but it has changed its mind. 🤷
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit a5df6f7 into kubernetes-sigs:master Feb 7, 2022
@vitorenesduarte vitorenesduarte mentioned this pull request Feb 25, 2022
Closed
@zeeke zeeke mentioned this pull request Apr 7, 2022
Closed
@swatisehgal swatisehgal mentioned this pull request May 19, 2022
Merged
@wrongerror wrongerror mentioned this pull request Jun 9, 2022
Merged
mbaldessari added a commit to mbaldessari/patterns-operator that referenced this pull request Jul 5, 2022
@mbaldessari
Upgrade kustomize version to v4.5.2
9ce96fc 
The 3.8.x version constantly errors with go modules:
go install sigs.k8s.io/kustomize/kustomize/v3@v3.8.7: sigs.k8s.io/kustomize/kustomize/v3@v3.8.7
        The go.mod file for the module providing named packages contains one or
        more exclude directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.

See kubernetes-sigs/kustomize#3618

This is fixed in kubernetes-sigs/kustomize#4387
and kustomize v4.5.2

In the future, once we will switch to operator-sdk 1.22 there will be a
separate script to install kustomize:
https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh
mbaldessari added a commit to mbaldessari/patterns-operator that referenced this pull request Jul 5, 2022
@mbaldessari
Upgrade kustomize version to v4.5.2
f9223a4 
The 3.8.x version constantly errors with go modules:
go install sigs.k8s.io/kustomize/kustomize/v3@v3.8.7: sigs.k8s.io/kustomize/kustomize/v3@v3.8.7
        The go.mod file for the module providing named packages contains one or
        more exclude directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.

See kubernetes-sigs/kustomize#3618

This is fixed in kubernetes-sigs/kustomize#4387
and kustomize v4.5.2

In the future, once we will switch to operator-sdk 1.22 there will be a
separate script to install kustomize:
https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/hack/install_kustomize.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey Awaiting requested review from KnVerey

@monopole monopole Awaiting requested review from monopole

Assignees

@KnVerey KnVerey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Neo2308 @k8s-ci-robot @KnVerey