-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set FieldPath for SequenceNode elements #4425
fix: set FieldPath for SequenceNode elements #4425
Conversation
Hi @sdowell. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL at the CI failure, other than that LGTM.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: natasha41575, sdowell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The FieldPath was not being set for nodes underneath a SequenceNode during fieldspec's traversal. This is in part because handleSequence uses VisitElements in contrast to a PathGetter as is done by handleMap. The accuracy of FieldPath is more relevant now with the recently added support of mutation trackers in filtersutil. This change fixes the case where a mutation tracker callback is called on a SequenceNode element and the node does not have an accurate FieldPath value.
9f078f4
to
9abf5fc
Compare
@natasha41575 Looks like I forgot to run |
/lgtm |
The FieldPath was not being set for nodes underneath a SequenceNode
during fieldspec's traversal. This is in part because handleSequence
uses VisitElements in contrast to a PathGetter as is done by handleMap.
The accuracy of FieldPath is more relevant now with the recently added
support of mutation trackers in filtersutil. This change fixes the
case where a mutation tracker callback is called on a SequenceNode
element and the node does not have an accurate FieldPath value.
For example:
For the above input, the following
FieldPath
would be seen for theimage
node from the perspective of a mutationTracker:Before this change:
image
After this change:
spec.containers.image