Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the kube-openapi version that matches latest client-go #4592

Closed
wants to merge 1 commit into from

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Apr 19, 2022

Per kubernetes/kube-openapi#285 (comment), the kube-openapi version being used should not be too new, otherwise it won't compile due to the breaking changes in kubernetes/kube-openapi#285.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mengqiy
To complete the pull request process, please assign natasha41575 after the PR has been reviewed.
You can assign the PR to them by writing /assign @natasha41575 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 19, 2022
@k8s-ci-robot
Copy link
Contributor

@mengqiy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kustomize-presubmit-master 9eeed2e link true /test kustomize-presubmit-master

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mengqiy mengqiy closed this Apr 19, 2022
@mengqiy mengqiy deleted the kubeopenapi branch April 19, 2022 22:57
@natasha41575
Copy link
Contributor

natasha41575 commented Apr 19, 2022

Seems like you've already realized this, but we need kubernetes/kube-openapi@b28bf28 to get the openapi performance boost and we can't reintroduce dependencies on the old namegithub.com/googleapis/gnostic per request from kubectl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants