expand and clean up repospec_test

[mightyguava]

Clean-ups for #4640. I think the unit test coverage for the repospec parsing is fairly comprehensive already. I decided to harden the tests for regression a little bit and add a couple cases that were missing.

This PR is smaller than it looks. It

• Adds a few SSH tests to TestNewRepoSpecFromUrl_CloneSpecs
• Adds additional regression coverage to TestNewRepoSpecFromUrl_CloneSpecs by also checking the structure of the full RepoSpec object.
• Moves vars and helpers for TestNewRepoSpecFromUrl into the test function
• Makes table tests run in deterministic order (ordering them using an array instead of map)

[k8s-ci-robot]

Hi @mightyguava. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[KnVerey]

/approve
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, mightyguava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KnVerey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KnVerey]

/lgtm