Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for helm --no-hooks flag #4808

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add support for helm --no-hooks flag #4808

merged 1 commit into from
Oct 10, 2022

Conversation

larsks
Copy link
Contributor

@larsks larsks commented Sep 26, 2022

This commit adds the skipHooks option to the helm chart support in order
to expose the --no-hooks flag introduced to Helm in 1.

Using Kustomize to inflate a Helm chart would in some situations result in
different results than using helm install. This is because helm template, by default, will render chart tests in the templates/test
directory, which can lead to undesired resources in the output.

See 2 for additional discussion.

Signed-off-by: Lars Kellogg-Stedman lars@oddbit.com

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @larsks. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 27, 2022
natasha41575
natasha41575 reviewed Sep 28, 2022
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is fine, as it is in line with our long term support plan for helm. Just one request for a test if that's possible.

plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go Show resolved Hide resolved
@natasha41575
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 28, 2022
natasha41575
natasha41575 reviewed Oct 7, 2022
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Could you also add this to to our helm chart documentation? it lives here:
https://github.com/kubernetes-sigs/cli-experimental/blob/master/site/content/en/references/kustomize/builtins/_index.md#helmchartinflationgenerator

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: larsks, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@natasha41575
Copy link
Contributor

Oh, looks like there's a lint error. I can re-LGTM when you update.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2022
@larsks
Add support for helm --no-hooks flag
38da7ca 
This commit adds the `skipHooks` option to the helm chart support in order
to  expose the --no-hooks flag introduced to Helm in [1].

Using Kustomize to inflate a Helm chart would in some situations result in
different results than using `helm install`. This is because `helm
template`, by default, will render chart tests in the `templates/test`
directory, which can lead to undesired resources in the output.

See [2] for additional discussion.

[1]: helm/helm#6444
[2]: helm/helm#6443

Signed-off-by: Lars Kellogg-Stedman <lars@oddbit.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 7, 2022
larsks added a commit to larsks/cli-experimental that referenced this pull request Oct 7, 2022
@larsks
Document skipHooks helm chart option
1db35f2 
Add documentation for the skipHooks option introduced in
kubernetes-sigs/kustomize#4808.
@larsks larsks mentioned this pull request Oct 7, 2022
Merged
@larsks
Copy link
Contributor Author

larsks commented Oct 7, 2022

@natasha41575 I fixed the linting error and added a docs pull request at kubernetes-sigs/cli-experimental#299

@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0a16b6c into kubernetes-sigs:master Oct 10, 2022
larsks added a commit to larsks/cli-experimental that referenced this pull request Oct 11, 2022
@larsks
Document skipHooks helm chart option
2574644 
Add documentation for the skipHooks option introduced in
kubernetes-sigs/kustomize#4808.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@larsks @k8s-ci-robot @natasha41575