Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability of ifc.Loader's Repo() method #4857

Merged
merged 4 commits into from
Nov 8, 2022
Merged

Improve readability of ifc.Loader's Repo() method #4857

merged 4 commits into from
Nov 8, 2022

Conversation

annasong20
Copy link
Contributor

This PR aims to improve the readability of ifc.Loader's Repo() method by simplifying its output. It addresses comment #4797 (comment) on PR #4797.

@k8s-ci-robot
Copy link
Contributor

@annasong20: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2022
@annasong20
Copy link
Contributor Author

linter currently failing due to previous change to master; #4854 should fix this, so I won't do anything here

@annasong20 annasong20 mentioned this pull request Nov 5, 2022
Closed
yuwenma
yuwenma reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. one minor comment.

natasha41575
natasha41575 reviewed Nov 7, 2022
View reviewed changes
api/internal/localizer/locloader.go Outdated Show resolved Hide resolved
api/internal/localizer/locloader.go Outdated Show resolved Hide resolved
@natasha41575
Copy link
Contributor

My comments are just nits, so will defer to Yuwen to give her LGTM when the code seems readable enough. Feel free to remove the hold when you are ready.

/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2022
@natasha41575 natasha41575 added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 7, 2022
yuwenma
yuwenma approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some super minor comments. Approved

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: annasong20, natasha41575, yuwenma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuwenma
Copy link
Contributor

yuwenma commented Nov 8, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2022
@annasong20
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@annasong20
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@annasong20
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit beb2825 into kubernetes-sigs:master Nov 8, 2022
@annasong20 annasong20 deleted the fix-ldr-repo branch November 8, 2022 22:51
elisshafer pushed a commit to elisshafer/kustomize that referenced this pull request Dec 8, 2022
@annasong20 @elisshafer
Improve readability of ifc.Loader's Repo() method (kubernetes-sig…
5f44d5f 
…s#4857)

* Improve ldr Repo() method readability

* Change Repo() implementations and calls

* Improve readability of conditions in ldr.New()

* Fix details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@yuwenma yuwenma yuwenma approved these changes

Assignees

@yuwenma yuwenma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@annasong20 @k8s-ci-robot @natasha41575 @yuwenma