Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: all module net and text dependent package CVE-2022-41717 and CVE-2022-32149 vulnerabilities #4889

Merged
merged 1 commit into from Jan 9, 2023
Merged

fix: all module net and text dependent package CVE-2022-41717 and CVE-2022-32149 vulnerabilities #4889

merged 1 commit into from Jan 9, 2023

Conversation

fengshunli
Copy link
Contributor

@fengshunli fengshunli commented Nov 26, 2022 •
edited

Signed-off-by: fsl 1171313930@qq.com

image

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @fengshunli!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @fengshunli. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 26, 2022
@erikgb
Copy link

erikgb commented Nov 26, 2022

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 26, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2022
@KnVerey
Copy link
Contributor

KnVerey commented Nov 30, 2022

This repo has a large number of modules, and many others also have indirect dependencies on those two packages. Can you please update all of them?

@fengshunli
Copy link
Contributor Author

This repo has a large number of modules, and many others also have indirect dependencies on those two packages. Can you please update all of them?

yes, it has been updated

@KnVerey
Copy link
Contributor

KnVerey commented Nov 30, 2022

This repo has a large number of modules, and many others also have indirect dependencies on those two packages. Can you please update all of them?

yes, it has been updated

Perhaps you forgot to push a new commit? I'm still only seeing changes to the one module

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 1, 2022
@fengshunli
Copy link
Contributor Author

This repo has a large number of modules, and many others also have indirect dependencies on those two packages. Can you please update all of them?

yes, it has been updated

Perhaps you forgot to push a new commit? I'm still only seeing changes to the one module

update

@KnVerey
Copy link
Contributor

KnVerey commented Dec 1, 2022

The latest push still only changes kustomize/go.mod and kustomize/go.sum, not any of the other modules.

@KnVerey KnVerey added this to the v5.0.0 milestone Dec 6, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 9, 2022
@fengshunli fengshunli changed the title fix: vulnerabilities in dependency package hints fix: golang.org/x/net vuln CVE-2022-41717 Dec 9, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 9, 2022
@fengshunli fengshunli changed the title fix: golang.org/x/net vuln CVE-2022-41717 fix: all module net and text dependent package CVE-2022-41717 and CVE-2022-32149 vulnerabilities Dec 9, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2022
@fengshunli
Copy link
Contributor Author

The latest push still only changes kustomize/go.mod and kustomize/go.sum, not any of the other modules.
ok

KnVerey
KnVerey reviewed Jan 6, 2023
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've got all the modules now, thanks! Please remove the unrelated bump, and run make test-go-mod to pick up a few missed .sum updates.

kustomize/go.mod Outdated Show resolved Hide resolved
@fengshunli
fix: all module net and text dependent package CVE-2022-41717 and CVE…
32f31c3 
…-2022-32149 vulnerabilities

Signed-off-by: fsl <1171313930@qq.com>
@KnVerey
Copy link
Contributor

KnVerey commented Jan 9, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fengshunli, KnVerey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4456221 into kubernetes-sigs:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey KnVerey left review comments

@natasha41575 natasha41575 Awaiting requested review from natasha41575

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@erikgb erikgb

@KnVerey KnVerey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fengshunli @k8s-ci-robot @erikgb @KnVerey