Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Orgrepo and Path #4922

Merged
merged 22 commits into from
Jan 9, 2023
Merged

Rename Orgrepo and Path #4922

merged 22 commits into from
Jan 9, 2023

Conversation

kishorerj
Copy link
Contributor

Changes Refactor repospec Issue :#4866.
rename OrgRepo to RepoPath. Rename Path to KustRootPath to clarify that it isn't the repo or clone root

@k8s-ci-robot
Copy link
Contributor

@kishorerj: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @kishorerj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 9, 2022
@kishorerj
Copy link
Contributor Author

/assign @annasong20 @natasha41575

@kishorerj kishorerj mentioned this pull request Dec 9, 2022
Closed
4 tasks
@annasong20
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 13, 2022
annasong20
annasong20 reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@annasong20 annasong20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Looks great! I left some optional comments.

api/internal/git/repospec.go Outdated Show resolved Hide resolved
api/internal/git/repospec.go Outdated Show resolved Hide resolved
api/internal/git/repospec_test.go Outdated Show resolved Hide resolved
@annasong20
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@annasong20
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@kishorerj
Copy link
Contributor Author

@annasong20 @natasha41575 @KnVerey The nit comments have been resolved and checked in

@annasong20
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@KnVerey
Copy link
Contributor

KnVerey commented Jan 4, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorerj, KnVerey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2023
annasong20 and others added 16 commits January 8, 2023 14:10
@annasong20 @kishorerj
Localize patchesJson6902, patchesStrategicMerge, replacements (kubern…
1e1742f 
…etes-sigs#4904)

* Localize patchesJson6902, patchesStrategicMerge, replacements

* Address code review feedback

* Improve readability
* Remove deprecation warning check
@annasong20 @kishorerj
Load legacy kustomization fields for localize (kubernetes-sigs#4918)
661ebad 
* Load legacy kustomization

* Expose loadKustFile in kusttarget
@koba1t @kishorerj
remove FixKustomizationPreUnmarshalling
04e51ad
@natasha41575 @kishorerj
remove deprecated cfg and fn commands (kubernetes-sigs#4930)
761ea31 
* remove deprecated cfg and fn commands

* fix lint error

* run gofmt
@annasong20 @kishorerj
Localize PatchTransformer, PatchJson6902Transformer (kubernetes-sigs#…
8a4efa2 
…4920)

* Localize patches, patchesJson6902 custom transformers

* Improve readability
@annasong20 @kishorerj
Localize fields: openapi, configurations, crds (kubernetes-sigs#4907)
a0bd001 
* Localize openapi, configurations, crds

* Add integration test

* Move krusty test

* Address code review feedback
@annasong20 @kishorerj
Implement locRootPath (kubernetes-sigs#4909)
68e0b10 
* Implement locRootPath, and include userinfo, port in locFilePath

* Strip userinfo, port

* Improve readability
@annasong20 @kishorerj
Localize legacy fields
08e5eca
@annasong20 @kishorerj
Localize resources (kubernetes-sigs#4912)
6736c37 
* Localize resources

* Improve readability

* Add integration tests

* Group test helper functions
@kishorerj
Remove Functionality that Pulls Env Variables from Empty Keys
16f2b88
@cailynse @KnVerey @kishorerj
Update api/kv/kv.go
e0ca562 
Co-authored-by: Katrina Verey <kn.verey@gmail.com>
@koba1t @kishorerj
refactor Unmarshal Kustomization struct code
f8f3caa
@koba1t @kishorerj
improve error messages
e4a4162
@KnVerey @kishorerj
Run go mod tidy on all modules before update
1f1fabe
@KnVerey @kishorerj
Update sigs.k8s.io/yaml to 1.3.0
e869551
@kishorerj
fixed test failure because of latest commits
a0dcfeb
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 8, 2023
@kishorerj
Copy link
Contributor Author

@annasong20 @KnVerey @natasha41575 Fixed the test failure because of further commits..Please review

@annasong20
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 772fafa into kubernetes-sigs:master Jan 9, 2023
cailynse added a commit to cailynse/kustomize that referenced this pull request Jan 12, 2023
@kishorerj @larsks
@annasong20 @koba1t @natasha41575 @cailynse @KnVerey
Rename Orgrepo and Path (kubernetes-sigs#4922)
8e5ae2b 
* initial changes to rename OrgRepo to RepoPath

* changes to rename Path to KustRootPath

* addressed review comments

* addressed review comments

* docs: Add documentation for namespace transformer

Add a short description of the namespace transformer and example
usage to examples/transformerconfigs/README.md.

References: kubernetes-sigs#629
Signed-off-by: Lars Kellogg-Stedman <lars@oddbit.com>

* Localize patchesJson6902, patchesStrategicMerge, replacements (kubernetes-sigs#4904)

* Localize patchesJson6902, patchesStrategicMerge, replacements

* Address code review feedback

* Improve readability
* Remove deprecation warning check

* Load legacy kustomization fields for `localize` (kubernetes-sigs#4918)

* Load legacy kustomization

* Expose loadKustFile in kusttarget

* remove FixKustomizationPreUnmarshalling

* remove deprecated cfg and fn commands (kubernetes-sigs#4930)

* remove deprecated cfg and fn commands

* fix lint error

* run gofmt

* Localize PatchTransformer, PatchJson6902Transformer (kubernetes-sigs#4920)

* Localize patches, patchesJson6902 custom transformers

* Improve readability

* Localize fields: openapi, configurations, crds (kubernetes-sigs#4907)

* Localize openapi, configurations, crds

* Add integration test

* Move krusty test

* Address code review feedback

* Implement locRootPath (kubernetes-sigs#4909)

* Implement locRootPath, and include userinfo, port in locFilePath

* Strip userinfo, port

* Improve readability

* Localize legacy fields

* Localize resources (kubernetes-sigs#4912)

* Localize resources

* Improve readability

* Add integration tests

* Group test helper functions

* Remove Functionality that Pulls Env Variables from Empty Keys

* Update api/kv/kv.go

Co-authored-by: Katrina Verey <kn.verey@gmail.com>

* refactor Unmarshal Kustomization struct code

* improve error messages

* Run go mod tidy on all modules before update

* Update sigs.k8s.io/yaml to 1.3.0

* fixed test failure because of latest commits

Signed-off-by: Lars Kellogg-Stedman <lars@oddbit.com>
Co-authored-by: Lars Kellogg-Stedman <lars@oddbit.com>
Co-authored-by: Anna Song <annasong@google.com>
Co-authored-by: yugo kobayashi <kobdotsh@gmail.com>
Co-authored-by: Natasha Sarkar <natashasarkar@google.com>
Co-authored-by: Cailyn Edwards <cailyn.edwards@shopify.com>
Co-authored-by: Cailyn <cailyn.s.e@gmail.com>
Co-authored-by: Katrina Verey <kn.verey@gmail.com>
Co-authored-by: Katrina Verey <katrina.verey@shopify.com>
annasong20 added a commit to annasong20/kustomize that referenced this pull request Jan 12, 2023
@kishorerj @larsks
@annasong20 @koba1t @natasha41575 @cailynse @KnVerey
Rename Orgrepo and Path (kubernetes-sigs#4922)
457d1c6 
* initial changes to rename OrgRepo to RepoPath

* changes to rename Path to KustRootPath

* addressed review comments

* addressed review comments

* docs: Add documentation for namespace transformer

Add a short description of the namespace transformer and example
usage to examples/transformerconfigs/README.md.

References: kubernetes-sigs#629
Signed-off-by: Lars Kellogg-Stedman <lars@oddbit.com>

* Localize patchesJson6902, patchesStrategicMerge, replacements (kubernetes-sigs#4904)

* Localize patchesJson6902, patchesStrategicMerge, replacements

* Address code review feedback

* Improve readability
* Remove deprecation warning check

* Load legacy kustomization fields for `localize` (kubernetes-sigs#4918)

* Load legacy kustomization

* Expose loadKustFile in kusttarget

* remove FixKustomizationPreUnmarshalling

* remove deprecated cfg and fn commands (kubernetes-sigs#4930)

* remove deprecated cfg and fn commands

* fix lint error

* run gofmt

* Localize PatchTransformer, PatchJson6902Transformer (kubernetes-sigs#4920)

* Localize patches, patchesJson6902 custom transformers

* Improve readability

* Localize fields: openapi, configurations, crds (kubernetes-sigs#4907)

* Localize openapi, configurations, crds

* Add integration test

* Move krusty test

* Address code review feedback

* Implement locRootPath (kubernetes-sigs#4909)

* Implement locRootPath, and include userinfo, port in locFilePath

* Strip userinfo, port

* Improve readability

* Localize legacy fields

* Localize resources (kubernetes-sigs#4912)

* Localize resources

* Improve readability

* Add integration tests

* Group test helper functions

* Remove Functionality that Pulls Env Variables from Empty Keys

* Update api/kv/kv.go

Co-authored-by: Katrina Verey <kn.verey@gmail.com>

* refactor Unmarshal Kustomization struct code

* improve error messages

* Run go mod tidy on all modules before update

* Update sigs.k8s.io/yaml to 1.3.0

* fixed test failure because of latest commits

Signed-off-by: Lars Kellogg-Stedman <lars@oddbit.com>
Co-authored-by: Lars Kellogg-Stedman <lars@oddbit.com>
Co-authored-by: Anna Song <annasong@google.com>
Co-authored-by: yugo kobayashi <kobdotsh@gmail.com>
Co-authored-by: Natasha Sarkar <natashasarkar@google.com>
Co-authored-by: Cailyn Edwards <cailyn.edwards@shopify.com>
Co-authored-by: Cailyn <cailyn.s.e@gmail.com>
Co-authored-by: Katrina Verey <kn.verey@gmail.com>
Co-authored-by: Katrina Verey <katrina.verey@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annasong20 annasong20 annasong20 left review comments

@KnVerey KnVerey Awaiting requested review from KnVerey

@koba1t koba1t Awaiting requested review from koba1t

Assignees

@natasha41575 natasha41575

@annasong20 annasong20

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kishorerj @k8s-ci-robot @annasong20 @KnVerey @natasha41575 @larsks @koba1t @cailynse