Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow path starting with slash #4947

Conversation

Azhovan
Copy link
Contributor

@Azhovan Azhovan commented Dec 26, 2022

Problem :
I started using Transformer Configurations with the following spec:

directory structure:

├── kustomization.yaml
├── namespace.yaml
└── resource.yaml

➜ cat kustomization.yaml

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
namespace: ns1

resources:
- resource.yaml

configurations:
  - namespace.yaml

➜ cat resource.yaml

apiVersion: apps/v1
kind: Deployment
metadata:
  labels:
    app: web-1
  name: web-1
spec:
  replicas: 1
  selector:
    matchLabels:
      app: web-1
  strategy: {}
  template:
    metadata:
      labels:
        app: web-1
    spec:
      containers:
      - image: nginx
        name: nginx

➜ cat namespace.yaml

namespace:
  - kind: Deployment
    path: metadata/namespace
    create: true

I noticed when path in namespace.yaml starts with a slash i.e /metadata/namespace PathSplitter function returns a slice of strings where first element is an empty string, causing kustomize to return an error like this, when I ran:
kustomize build .
in root of the directory.

Error: namespace transformation failed: considering field '/metadata/namespace' 
of object Deployment.v1.apps/web-1.ns1: cannot set or create an empty field name

handling this forward slash at the beginning of a path seems to make working with kustomize easier

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 26, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Azhovan / name: Jabar Asadi (368697f)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 26, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Azhovan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @Azhovan!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 26, 2022
@Azhovan Azhovan changed the title feat: Allow paths starting with slash feat: Allow path starting with slash Dec 26, 2022
@Azhovan
Copy link
Contributor Author

Azhovan commented Dec 29, 2022

@KnVerey @natasha41575
do you find this change relevant?

@Azhovan
Copy link
Contributor Author

Azhovan commented Jan 4, 2023

/assign @phanimarupaka

@Azhovan
Copy link
Contributor Author

Azhovan commented Jan 12, 2023

@phanimarupaka @mortent
Kindly a reminder,
If this is not relevant, let's close it?

@KnVerey
Copy link
Contributor

KnVerey commented Jan 14, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 14, 2023
@natasha41575 natasha41575 requested review from KnVerey and natasha41575 and removed request for mortent and phanimarupaka January 17, 2023 20:02
@natasha41575
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2023
@KnVerey
Copy link
Contributor

KnVerey commented Jan 17, 2023

/approve

Thanks for the contribution!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Azhovan, KnVerey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit def01f0 into kubernetes-sigs:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants