Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s.io/kube-openapi to remove archived dependency #4965

Merged
merged 1 commit into from Jan 14, 2023
Merged

Bump k8s.io/kube-openapi to remove archived dependency #4965

merged 1 commit into from Jan 14, 2023

Conversation

olivierlemasle
Copy link
Member

Bump k8s.io/kube-openapi to remove archived dependency github.com/PuerkitoBio/urlesc

Fixes #4962

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2023
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 9, 2023
@pacoxu
Copy link
Member

pacoxu commented Jan 10, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@olivierlemasle
Copy link
Member Author

/assign @KnVerey

KnVerey
KnVerey reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record the diff is kubernetes/kube-openapi@b28bf28...3758b55. Since whatever k/k is using for this dependency is canonical for us too, and our tests pass, I'm not concerned.

cmd/gorepomod/go.mod
require golang.org/x/mod v0.4.2

require golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
require golang.org/x/mod v0.7.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this bump related somehow?

api/go.mod
@@ -8,32 +8,29 @@ require (
github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510
github.com/imdario/mergo v0.3.6
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.8.0
github.com/stretchr/testify v1.8.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this bump related somehow? Usually we want each dep in its own PR, but in this case I don't mind too much because testify is a tests-only dep.

@olivierlemasle
Copy link
Member Author

Yes @KnVerey, the only command I passed was:

hack/for-each-module.sh "go list -m -u k8s.io/kube-openapi && go get k8s.io/kube-openapi@3758b55a65962062abe14021c50eade1475f67e3 && go mod tidy"

The other modules that were upgraded in the process (github.com/stretchr/testify, golang.org/x/mod) were upgraded automatically as dependencies of k8s.io/kube-openapi.

@olivierlemasle
Bump k8s.io/kube-openapi to remove archived dependency
aaf9d39 
Bump k8s.io/kube-openapi to remove archived dependency github.com/PuerkitoBio/urlesc
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2023
@olivierlemasle
Copy link
Member Author

@KnVerey I just rebased on master, because of merge conflicts.

@olivierlemasle
Copy link
Member Author

/retest

@KnVerey
Copy link
Contributor

KnVerey commented Jan 14, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KnVerey, olivierlemasle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit db7b057 into kubernetes-sigs:master Jan 14, 2023
@olivierlemasle olivierlemasle deleted the puerkitobio-urlesc branch January 14, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey KnVerey left review comments

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@pacoxu pacoxu

@KnVerey KnVerey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PuerkitoBio/urlesc is archived
4 participants
@olivierlemasle @pacoxu @KnVerey @k8s-ci-robot