Remove Log Assignment to Stdout #5048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
KnVerey
reviewed
Feb 16, 2023
KnVerey
reviewed
Feb 16, 2023
cailynse
force-pushed
the
issue-5039
branch
2 times, most recently
from
850317b
to
10ab237
Compare
k8s-ci-robot
added
size/M
k8s-ci-robot
added
size/S
annasong20
suggested changes
Feb 21, 2023
| @@ -27,7 +26,6 @@ type flags struct { | |||
|
|
|||
| // NewCmdLocalize returns a new localize command. | |||
| func NewCmdLocalize(fs filesys.FileSystem, writer io.Writer) *cobra.Command { | |||
There was a problem hiding this comment.
super nit: We can replace "writer" with underscore "_" since we no longer use this argument.
k8s-ci-robot
added
size/M
cailynse
requested review from
annasong20
and removed request for
natasha41575
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cailynse, KnVerey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5039
The log output was changed to
writerhere, which is set to stdout here causing the log output to not be redirected with errors.Questions:
I don't fully understand why the change, and related test were there initially so I'm not confident my strategy of just removing them is the best option.